From 569b0bb3b92ca539da34d41d092deb8edb7a81ce Mon Sep 17 00:00:00 2001 From: "kaf24@firebug.cl.cam.ac.uk" Date: Mon, 19 Mar 2007 09:32:52 +0000 Subject: [PATCH] Add parentheses to trace_do_casts macro. The arguments to this macro didn't have parentheses around them where they were used. If a call to a TRACE macro included an expression as an argument, the cast to (unsigned long) could bind to just part of the expression and lead to unexpected results. Signed-off-by: Michael Vrable --- xen/include/xen/trace.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/include/xen/trace.h b/xen/include/xen/trace.h index 4f3649a394..cd1422bc09 100644 --- a/xen/include/xen/trace.h +++ b/xen/include/xen/trace.h @@ -41,11 +41,11 @@ void trace(u32 event, unsigned long d1, unsigned long d2, do { \ if ( unlikely(tb_init_done) ) \ trace(e, \ - (unsigned long)d1, \ - (unsigned long)d2, \ - (unsigned long)d3, \ - (unsigned long)d4, \ - (unsigned long)d5); \ + (unsigned long)(d1), \ + (unsigned long)(d2), \ + (unsigned long)(d3), \ + (unsigned long)(d4), \ + (unsigned long)(d5)); \ } while ( 0 ) /* Convenience macros for calling the trace function. */ -- 2.30.2